New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stache parser creating incorrect output #2229

Closed
ccummings opened this Issue Feb 2, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@ccummings
Contributor

ccummings commented Feb 2, 2016

Fiddle: http://jsfiddle.net/qYdwR/2600/

I would expect that to render:

<div>1.disabled=“disabled”</div>
<div disabled=“disabled”>2. test</div>

But it instead renders:

<div>1.disabled=“disabled”</div>
@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Feb 2, 2016

Contributor

https://github.com/canjs/canjs/blob/master/view/parser/parser.js#L300 is almost certainly where the error is. It should probably be counting starting #, ^ and ending / sections.

Contributor

justinbmeyer commented Feb 2, 2016

https://github.com/canjs/canjs/blob/master/view/parser/parser.js#L300 is almost certainly where the error is. It should probably be counting starting #, ^ and ending / sections.

@akagomez

This comment has been minimized.

Show comment
Hide comment
@akagomez
Contributor

akagomez commented Feb 2, 2016

@justinbmeyer justinbmeyer added the bug label Feb 4, 2016

@justinbmeyer justinbmeyer self-assigned this Feb 4, 2016

@justinbmeyer justinbmeyer added this to the 2.3.14 milestone Feb 4, 2016

@daffl daffl modified the milestones: 2.3.15, 2.3.14 Feb 5, 2016

@daffl daffl modified the milestones: 2.3.17, 2.3.16 Feb 17, 2016

justinbmeyer added a commit that referenced this issue Feb 18, 2016

@daffl daffl closed this in #2276 Feb 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment