New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form reset won't work with two-way bindings on elements. w/ CanJS 2.3.15 #2249

Closed
marshallswain opened this Issue Feb 9, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@marshallswain
Member

marshallswain commented Feb 9, 2016

Form elements with two way value bindings (using either the old can-value or new {($value)} syntax) do not reset when a form's reset button is clicked.

Here's an example JSBin with the old syntax: http://jsbin.com/hobolo/6/edit?html,js,output
Here's an example with the new syntax: http://jsbin.com/hobolo/3/edit?html,js,output

In the new version of Can, do these exist as a single implementation in the code? Meaning, does can-value use the same code as the new value bindings?

It looks like this has worked in the past. Here's the same JSBin with can@2.3.4
http://jsbin.com/hobolo/5/edit?html,js,output

@marshallswain

This comment has been minimized.

Show comment
Hide comment
@marshallswain

marshallswain Feb 9, 2016

Member

select boxes are resetting. So far it's only an issue with text inputs.

Member

marshallswain commented Feb 9, 2016

select boxes are resetting. So far it's only an issue with text inputs.

@marshallswain

This comment has been minimized.

Show comment
Hide comment
@marshallswain

marshallswain Feb 9, 2016

Member

Checkboxes work as expected (they clear on reset): http://jsbin.com/hobolo/6/edit?html,js,output

Member

marshallswain commented Feb 9, 2016

Checkboxes work as expected (they clear on reset): http://jsbin.com/hobolo/6/edit?html,js,output

@daffl daffl added this to the 2.3.18 milestone Feb 22, 2016

@ramblinjan ramblinjan self-assigned this Mar 2, 2016

@daffl daffl modified the milestones: 2.3.19, 2.3.18 Mar 3, 2016

@ramblinjan

This comment has been minimized.

Show comment
Hide comment
@ramblinjan

ramblinjan Mar 3, 2016

Contributor

Fixed in branch in #2302 except in amd with dojo--will bug someone later for help with that

Contributor

ramblinjan commented Mar 3, 2016

Fixed in branch in #2302 except in amd with dojo--will bug someone later for help with that

@daffl daffl modified the milestones: 2.3.20, 2.3.19 Mar 4, 2016

@daffl daffl closed this in #2302 Mar 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment