New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties with serialize: false should not be stringified #2396

Closed
kylegifford opened this Issue May 18, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@kylegifford
Contributor

kylegifford commented May 18, 2016

When upgrading to 2.3.16, I identified an issue caused by #2206. Properties are being stringified by can.route's .__type() and can.route.attr() methods, even if they should not be serialized (serialized: false). Example we saw was a Date object being stringified, which later caused errors when using it as a Date.

This was also reported in #2206 (comment).

@justinbmeyer justinbmeyer added this to the 2.3.24 milestone May 18, 2016

@kylegifford

This comment has been minimized.

Show comment
Hide comment
@kylegifford

kylegifford May 19, 2016

Contributor

It looks like this behavior was fixed in #2277. In my specific case, I had a reference to an object as part of two properties being set with can.route.attr. Because one of them did not have serialize: false set, the object was errantly stringified. Setting serialize: false on the second property fixes this issue after upgrading to v2.3.17. This issue can likely be closed.

Contributor

kylegifford commented May 19, 2016

It looks like this behavior was fixed in #2277. In my specific case, I had a reference to an object as part of two properties being set with can.route.attr. Because one of them did not have serialize: false set, the object was errantly stringified. Setting serialize: false on the second property fixes this issue after upgrading to v2.3.17. This issue can likely be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment