Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm distribution should have global/amd/umd files #2646

Open
BigAB opened this Issue Oct 28, 2016 · 3 comments

Comments

Projects
None yet
5 participants
@BigAB
Copy link
Contributor

BigAB commented Oct 28, 2016

Our npm package for can should include a dist folder with the built gloabal/amd stuff?

Currently our release tags do have global https://github.com/canjs/canjs/tree/v3.0.0-pre.17

I think it would be nice to have the amd and if possible a umd distribution file too. This would be good for anyone who uses npm for packages but not steal or webpack.

This would also make our stuff more available through the unpkg.com cdn which is good for demos and such.

@BigAB BigAB changed the title npm distribution should have global/amd/umd distributions npm distribution should have global/amd/umd files Oct 28, 2016

@justinbmeyer

This comment has been minimized.

Copy link
Contributor

justinbmeyer commented Oct 28, 2016

The individual repos may publish this (some do), but it's not canjs/canjs's job.

Browserify should work too. I think there's few people left on AMD alone.

Sent from my iPhone

On Oct 28, 2016, at 1:43 PM, Adam L Barrett notifications@github.com wrote:

Our npm package for can should include a dist folder with the built gloabal/amd stuff?

Currently our release tags do have global https://github.com/canjs/canjs/tree/v3.0.0-pre.17

I think it would be nice to have the amd and if possible a umd distribution file too. This would be good for anyone who uses npm for packages but not steal or webpack.

This would also make our stuff more available through the unpkg.com cdn which is good for demos and such.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@rjgotten

This comment has been minimized.

Copy link

rjgotten commented Nov 14, 2016

I think there's few people left on AMD alone.

Personally, as long as there's still a way to export CanJS in AMD format via pre-made build scripts, I don't mind a pre-built dist folder not being present. In that case it just trims the fat to not have it in the packages directly and it's just a few additional npm installs and CLI build tools away.

However, if you're suggesting AMD users should roll their own conversion from CJS -> AMD entirely, then I'm not so sure I'd be happy about that.

@roemhildtg

This comment has been minimized.

Copy link
Contributor

roemhildtg commented May 5, 2017

I had a chance to test the script here: https://gist.github.com/sszabolcs/3455514b8b7f418160966ed8fd169b8c and it works well for outputting an amd build of canjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.