New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`can.Mustache` live-binding on `can.route` attributes #351

Closed
amcdnl opened this Issue Apr 8, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@amcdnl
Contributor

amcdnl commented Apr 8, 2013

In can.Mustache on CanJS 1.1.5 if you live-bind on a route in the view like:

{{#route.id}}
    <a href="#">Edit Item</a>
{{/route.id}}

The page will error stating: http://screencast.com/t/LV9xchxWmaPv

You can do a workaround by doing: route.data.id but we should really handle the route case too.

@ghost ghost assigned imjoshdean Sep 30, 2013

@imjoshdean

This comment has been minimized.

Show comment
Hide comment
@imjoshdean

imjoshdean Sep 30, 2013

Contributor

This should be working like you want it, looking into it now.

Contributor

imjoshdean commented Sep 30, 2013

This should be working like you want it, looking into it now.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Sep 30, 2013

Contributor

I doubt it. Mustache incorrectly looks for properties on observables
directly. Using attr won't help because it sets up bindings.

On Monday, September 30, 2013, Josh Dean wrote:

This should be working, looking into it now.


Reply to this email directly or view it on GitHubhttps://github.com/canjs/canjs/issues/351#issuecomment-25372645
.

Justin Meyer
847-924-6039

Contributor

justinbmeyer commented Sep 30, 2013

I doubt it. Mustache incorrectly looks for properties on observables
directly. Using attr won't help because it sets up bindings.

On Monday, September 30, 2013, Josh Dean wrote:

This should be working, looking into it now.


Reply to this email directly or view it on GitHubhttps://github.com/canjs/canjs/issues/351#issuecomment-25372645
.

Justin Meyer
847-924-6039

@imjoshdean

This comment has been minimized.

Show comment
Hide comment
@imjoshdean

imjoshdean Oct 7, 2013

Contributor

Reopening, not working on 2.0/dev branch.

Contributor

imjoshdean commented Oct 7, 2013

Reopening, not working on 2.0/dev branch.

@imjoshdean imjoshdean reopened this Oct 7, 2013

imjoshdean added a commit that referenced this issue Oct 8, 2013

@imjoshdean imjoshdean closed this Oct 8, 2013

imjoshdean added a commit that referenced this issue Oct 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment