Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish implementation of new sidebar #3598

Closed
chasenlehara opened this Issue Sep 29, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@chasenlehara
Copy link
Member

chasenlehara commented Sep 29, 2017

  • Remove HTML from the link titles/descriptions
  • Display the correct “short title”
  • Fix support for @hide
  • Automatically expand sections when something under them is selected
  • Persist collapsed/expanded state
  • Increase the button size so it’s an easier target
  • Look into accessibility (do we need aria-pressed?)
  • After navigating to a page, its link should display in the sidebar’s viewport (related: canjs/bit-docs-html-canjs#339)
  • Fix selecting search results when on any page other than the home page
  • Animate showing/hiding modules
  • Change the focus indicator to only show on keyboard nav
  • Add more spacing between Routing and CORE
  • Make the +/- button a consistent width (and maybe - the same width as +)
  • Fix an animation hiccup when closing the sections that don’t start off with Core children
  • Convert the purpose pages to groups
  • Make the collection names links
  • Fix the search results styling
  • Don’t show groups in the search results
  • Fix console warnings by using https://github.com/canjs/can-stache/releases/tag/v3.13.0
  • Show the collections as selected when they’re clicked in the sidebar
  • Some of the widest items in the menu are cut off on mobile
  • Fix the jump when expanding sections with longer titles

@chasenlehara chasenlehara self-assigned this Sep 29, 2017

@chasenlehara

This comment has been minimized.

Copy link
Member Author

chasenlehara commented Oct 20, 2017

@justinbmeyer @phillipskevin I still have more work to do (see the list above), but you can play around with the new sidebar here: https://bit-docs.github.io/canjs/

@phillipskevin

This comment has been minimized.

Copy link
Collaborator

phillipskevin commented Oct 23, 2017

Looks great. The only thing that I think would help is to make it more obvious somehow which items were added when the + was clicked.

I'm not sure of a good solution to this, but it is sort of jarring when new items are added above the existing ones.

@imaustink

This comment has been minimized.

Copy link
Contributor

imaustink commented Oct 30, 2017

More issues found:

  • X button in search bar not visible on mobile [can’t reproduce]
@chasenlehara

This comment has been minimized.

Copy link
Member Author

chasenlehara commented Nov 1, 2017

Implementation is finished and deployed for testing here: https://bit-docs.github.io/canjs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.