Wrong variable name in the Guide. #431

Closed
dorajistyle opened this Issue Jun 14, 2013 · 9 comments

Comments

Projects
None yet
5 participants
@dorajistyle

http://canjs.com/guides/Observes.html

Section 'Converted Computes'.

Line 3. var progressPercentage

It should be 'var percentage'.

http://canjs.com/guides/Routing.html

Section 'If you give can.route a template, you can make pretty URLs:'.

Line 12. window.location.hash; // '#!users/7'

'#!users/7' should be '#!users/29'.

Have a nice day.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jun 14, 2013

Contributor

Thanks! You should be able to edit this guide in the Wiki (observes, routing). When we deploy the page again it should get updated. I'm also working on getting edit links on each page so that you can go there directly.

Contributor

daffl commented Jun 14, 2013

Thanks! You should be able to edit this guide in the Wiki (observes, routing). When we deploy the page again it should get updated. I'm also working on getting edit links on each page so that you can go there directly.

@codr

This comment has been minimized.

Show comment
Hide comment
@codr

codr Jul 22, 2013

It looks like the wiki is not open for public editing. I've made these changes on my fork but apparently we can't make a pull request for a wiki.

Is it possible to open the wiki for public editing?

codr commented Jul 22, 2013

It looks like the wiki is not open for public editing. I've made these changes on my fork but apparently we can't make a pull request for a wiki.

Is it possible to open the wiki for public editing?

@dorajistyle

This comment has been minimized.

Show comment
Hide comment
@dorajistyle

dorajistyle Jul 23, 2013

Yes. I can't edit the Wiki yet. And Github is not support Wiki pulling as well.

Yes. I can't edit the Wiki yet. And Github is not support Wiki pulling as well.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jul 23, 2013

Contributor

I think we will fix this soon. Thanks for pointing it out.

Contributor

justinbmeyer commented Jul 23, 2013

I think we will fix this soon. Thanks for pointing it out.

@codr

This comment has been minimized.

Show comment
Hide comment
@codr

codr Jul 25, 2013

How can this be fixed? Is opening the wiki for public editing an acceptable solution?

codr commented Jul 25, 2013

How can this be fixed? Is opening the wiki for public editing an acceptable solution?

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jul 25, 2013

Contributor

I'm still not sure how to solve this best. I wouldn't mind making it publicly editable (question is: how to do quality assurance before publishing it to the website?).

We were also thinking about simply moving the guides into the CanJS main repository where the API documentation is already coming from which can be edited using PRs.

Contributor

daffl commented Jul 25, 2013

I'm still not sure how to solve this best. I wouldn't mind making it publicly editable (question is: how to do quality assurance before publishing it to the website?).

We were also thinking about simply moving the guides into the CanJS main repository where the API documentation is already coming from which can be edited using PRs.

@codr

This comment has been minimized.

Show comment
Hide comment
@codr

codr Jul 25, 2013

What about moving the guides to the canjs.com repo?
It does seems a little weird to have a wiki with a bunch of @ tags in it.

codr commented Jul 25, 2013

What about moving the guides to the canjs.com repo?
It does seems a little weird to have a wiki with a bunch of @ tags in it.

@norm-mp

This comment has been minimized.

Show comment
Hide comment
@norm-mp

norm-mp Aug 9, 2013

On this page: http://canjs.com/guides/EJS.html

This code:
can.view('todosAndUser', {
todos: Todo.findAll(),
user: User.findOne({id: 5})
}).then(function(frag) {
document.getElementById('todos').appendChild(fragment);
});

Should be document.getElementById('todos').appendChild(frag);

norm-mp commented Aug 9, 2013

On this page: http://canjs.com/guides/EJS.html

This code:
can.view('todosAndUser', {
todos: Todo.findAll(),
user: User.findOne({id: 5})
}).then(function(frag) {
document.getElementById('todos').appendChild(fragment);
});

Should be document.getElementById('todos').appendChild(frag);

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Oct 11, 2013

Contributor

After a discussion with @justinbmeyer I think we are just going to put the guides in the main repository so that they can be updated with a pull request.

Contributor

daffl commented Oct 11, 2013

After a discussion with @justinbmeyer I think we are just going to put the guides in the main repository so that they can be updated with a pull request.

@daffl daffl closed this Oct 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment