recommended syntax breaks can.route #462

Closed
shcarrico opened this Issue Aug 21, 2013 · 1 comment

Comments

Projects
None yet
3 participants
@shcarrico
Contributor

shcarrico commented Aug 21, 2013

The documentation for http://canjs.com/docs/can.route.html has several inconsistencies:

! (hash-bang) is entered as !# (bang-hash) in multiple places

more importantly, can.route('#!foo/:id') breaks the pretty URL functionality of can.route. It should be can.route('foo/:id') without the hashbang..

This is not huge to fix, but is important as the recommended syntax causes the library to fail silently, producing 4 change events per update and a blank hash value...

@ghost ghost assigned imjoshdean Aug 21, 2013

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Aug 21, 2013

Contributor

thanks, but we've been adding documentation errors to the canjs.com repo:

https://github.com/bitovi/canjs.com. Can you add this there?

Contributor

justinbmeyer commented Aug 21, 2013

thanks, but we've been adding documentation errors to the canjs.com repo:

https://github.com/bitovi/canjs.com. Can you add this there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment