New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mustache two way helpers don't work as documented #469

Closed
azazel75 opened this Issue Aug 30, 2013 · 3 comments

Comments

Projects
None yet
4 participants
@azazel75

azazel75 commented Aug 30, 2013

In http://canjs.com/docs/can.Mustache.helper.html#section_Returninganelementcallbackfunction it is written that an helper that returns a function will be rendered with an element passed in and the two cases are those of having the helper within the tag and between the tags. It appears that just the former way of using it works as expected... bug or feature? ;-) For a test see:

http://jsfiddle.net/kve4H/2/

@ghost ghost assigned andykant Aug 30, 2013

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Aug 30, 2013

Contributor

I can confirm. @andykant Could you have a look at this?

Contributor

daffl commented Aug 30, 2013

I can confirm. @andykant Could you have a look at this?

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Aug 30, 2013

Contributor

It's broke. I know how to fix it. Submit a test and I will make this part of 1.2.

Sent from my iPhone

On Aug 30, 2013, at 1:58 PM, David Luecke notifications@github.com wrote:

I can confirm. @andykant Could you have a look at this?


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Aug 30, 2013

It's broke. I know how to fix it. Submit a test and I will make this part of 1.2.

Sent from my iPhone

On Aug 30, 2013, at 1:58 PM, David Luecke notifications@github.com wrote:

I can confirm. @andykant Could you have a look at this?


Reply to this email directly or view it on GitHub.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Aug 30, 2013

Contributor

I think we even might have enough bugs that are non-breaking to fix to get a 1.1.8 out next week if this is an easy fix. I can add a test.

Contributor

daffl commented Aug 30, 2013

I think we even might have enough bugs that are non-breaking to fix to get a 1.1.8 out next week if this is an easy fix. I can add a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment