New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live-Binding memory leak #666

Closed
daniel-franz opened this Issue Jan 15, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@daniel-franz
Contributor

daniel-franz commented Jan 15, 2014

It seems like there is a memory leak in live-binding as text-nodes are seemingly never removed from can.template.nodeLists.nodeMap. As text-nodes' parents don't have an attached nodeList they are never unbound.

Example: http://jsfiddle.net/y2BXn/1/

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jan 15, 2014

Contributor

I think this is a great catch. Here's a fiddle that shows it a bit more explicitly:

http://jsfiddle.net/donejs/y2BXn/2/

Thanks. I will fix this tonight.

Contributor

justinbmeyer commented Jan 15, 2014

I think this is a great catch. Here's a fiddle that shows it a bit more explicitly:

http://jsfiddle.net/donejs/y2BXn/2/

Thanks. I will fix this tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment