Wrong context in serialize of can.map.define #953

Closed
whitecolor opened this Issue May 3, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@whitecolor
Contributor

whitecolor commented May 3, 2014

It seems to be a wrong context inside serialize function ("this" is window object).

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer May 3, 2014

Contributor

https://github.com/bitovi/canjs/blob/minor/map/define/define.js#L220 looks like where this is happening, can you submit a pull request and test?

Contributor

justinbmeyer commented May 3, 2014

https://github.com/bitovi/canjs/blob/minor/map/define/define.js#L220 looks like where this is happening, can you submit a pull request and test?

@whitecolor

This comment has been minimized.

Show comment
Hide comment
@whitecolor

whitecolor May 3, 2014

Contributor

#959
two test, not sure if two pull request would be better.

Contributor

whitecolor commented May 3, 2014

#959
two test, not sure if two pull request would be better.

@ccummings ccummings added the Bug label May 7, 2014

@ccummings ccummings added this to the 2.1.1 milestone May 7, 2014

@ccummings

This comment has been minimized.

Show comment
Hide comment
@ccummings

ccummings May 16, 2014

Contributor

@whitecolor @justinbmeyer Is this fixed with #959 and #961?

Contributor

ccummings commented May 16, 2014

@whitecolor @justinbmeyer Is this fixed with #959 and #961?

@whitecolor

This comment has been minimized.

Show comment
Hide comment
@whitecolor

whitecolor May 16, 2014

Contributor

It seems to work ok now.

Contributor

whitecolor commented May 16, 2014

It seems to work ok now.

@ccummings

This comment has been minimized.

Show comment
Hide comment
@ccummings

ccummings May 16, 2014

Contributor

Great! thanks for checking.

Contributor

ccummings commented May 16, 2014

Great! thanks for checking.

@ccummings ccummings closed this May 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment