New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested component within an #if is not live bound #1025

Merged
merged 1 commit into from Jun 9, 2014

Conversation

Projects
None yet
3 participants
@alexisabril
Contributor

alexisabril commented Jun 2, 2014

if around a child component, live binds on the initial change of a compute, however is not updated on subsequent compute updates. The parent component does receive compute change events correctly.

alexisabril pushed a commit that referenced this pull request May 29, 2014

@shcarrico

This comment has been minimized.

Show comment
Hide comment
@shcarrico

shcarrico May 29, 2014

Contributor

maybe is related to #1019 ?

Contributor

shcarrico commented May 29, 2014

maybe is related to #1019 ?

@alexisabril

This comment has been minimized.

Show comment
Hide comment
@alexisabril

alexisabril May 29, 2014

Contributor

Very possible. I was looking that issue as well. I wrote another test as #if seems to work with other DOM elements, just seems to halt calling the helper in situations with a nested component. That being said, the logic to fix this very well maybe related.

Contributor

alexisabril commented May 29, 2014

Very possible. I was looking that issue as well. I wrote another test as #if seems to work with other DOM elements, just seems to halt calling the helper in situations with a nested component. That being said, the logic to fix this very well maybe related.

@alexisabril

This comment has been minimized.

Show comment
Hide comment
@alexisabril

alexisabril May 30, 2014

Contributor

This is actually an issue with custom helpers as well.

Contributor

alexisabril commented May 30, 2014

This is actually an issue with custom helpers as well.

@alexisabril

This comment has been minimized.

Show comment
Hide comment
@alexisabril

alexisabril Jun 2, 2014

Contributor

@shcarrico I just tested this fix with #1019. They appear to be separate issues. #1025 turned out to be specific to stache.

Contributor

alexisabril commented Jun 2, 2014

@shcarrico I just tested this fix with #1019. They appear to be separate issues. #1025 turned out to be specific to stache.

@daffl daffl added this to the 2.1.2 milestone Jun 2, 2014

daffl added a commit that referenced this pull request Jun 9, 2014

Merge pull request #1025 from bitovi/1025-nested-compute
nested component within an #if is not live bound

@daffl daffl merged commit af14768 into master Jun 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@daffl daffl deleted the 1025-nested-compute branch Jun 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment