Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Map define warn #1041
I've seen a few times that people forget to add the define plugin and it fails silently. This is an attempt to add a warning so its obvious right away.
@daffl that test wouldn't work without a map definition
@justinbmeyer lately we've been adding warnings for "silent failure" type things, like wrong property names in a mustache template. Most plugins don't fail silently, they define a function that gets called and user code throws an error without it, or something similar. This fails silently.
I added a better check, the problem was there is nothing special defined in the define plugin that could be inspected for feature detection code, so I changed the function stub. Do you see any reason this could be bad?