Making routes not greedily consume slashes by default #1044

Merged
merged 2 commits into from Jun 13, 2014

Conversation

Projects
None yet
4 participants
@moschel
Contributor

moschel commented Jun 3, 2014

Adds a flag to turn this behavior off. Also makes it so you can call .root with the domain included, which wasn't working before.

@justinbmeyer I looked through the route issues and didn't see anything related to this. Added a flag anyways (matchSlashes, which defaults to false) so if this breaks someone's code they can flip it off.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jun 3, 2014

Contributor

The build failed.

Contributor

justinbmeyer commented Jun 3, 2014

The build failed.

@moschel

This comment has been minimized.

Show comment
Hide comment
@moschel

moschel Jun 3, 2014

Contributor

I think there's something wrong with the build. Its not failing locally in the same place, it just randomly timed out. But it was also timing out when I ran it from master in another spot.

Contributor

moschel commented Jun 3, 2014

I think there's something wrong with the build. Its not failing locally in the same place, it just randomly timed out. But it was also timing out when I ran it from master in another spot.

@moschel

This comment has been minimized.

Show comment
Hide comment
@moschel

moschel Jun 3, 2014

Contributor

I don't think that failure is actually related to this commit.

Contributor

moschel commented Jun 3, 2014

I don't think that failure is actually related to this commit.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jun 3, 2014

Contributor

I would make sure.

Contributor

justinbmeyer commented Jun 3, 2014

I would make sure.

@daffl daffl modified the milestones: 2.1.3, 2.1.2 Jun 10, 2014

moschel and others added some commits Jun 3, 2014

fixes #1027 making routes not greedily consume slashes by default, b…
…ut adding a flag to turn this behavior off
Add teardown to pushstate tests
update qunit and get rid of using steal.root in a test as it won't work in production

daffl added a commit that referenced this pull request Jun 13, 2014

Merge pull request #1044 from bitovi/1027-greedy-routes
Making routes not greedily consume slashes by default

@daffl daffl merged commit 2353887 into master Jun 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@daffl daffl deleted the 1027-greedy-routes branch Jun 13, 2014

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jun 13, 2014

Contributor

@moschel can you add some docs?

Contributor

justinbmeyer commented Jun 13, 2014

@moschel can you add some docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment