New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings for map/define #1054

Merged
merged 1 commit into from Jun 10, 2014

Conversation

Projects
None yet
2 participants
@moschel
Contributor

moschel commented Jun 5, 2014

fixes #1041

Adds 2 warnings:

  1. when someone tries to add a define property but haven't included the define plugin
  2. when someone tries to add define on static props, not prototype props
@moschel

This comment has been minimized.

Show comment
Hide comment
@moschel

moschel Jun 5, 2014

Contributor

This is the same as #1041 but on master, not minor

Contributor

moschel commented Jun 5, 2014

This is the same as #1041 but on master, not minor

@daffl daffl added this to the 2.1.2 milestone Jun 6, 2014

daffl added a commit that referenced this pull request Jun 10, 2014

@daffl daffl merged commit 73a7c98 into master Jun 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@daffl daffl deleted the map-define-warn-master branch Jun 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment