New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.Construct passes original arguments to setup and fixes can.Model's setup accordingly #1099

Merged
merged 3 commits into from Jun 19, 2014

Conversation

Projects
None yet
3 participants
@justinbmeyer
Contributor

justinbmeyer commented Jun 18, 2014

Fixes #1034.

Arguments was being modified in can.Construct.extend causing the incorrect values passed to setup functions.

Typeof was not used when checking if fullName was passed.

@daffl daffl added this to the 2.1.3 milestone Jun 18, 2014

@daffl daffl added the Bug label Jun 19, 2014

daffl added a commit that referenced this pull request Jun 19, 2014

Merge pull request #1099 from bitovi/fixes-1034
can.Construct passes original arguments to setup and fixes can.Model's setup accordingly

@daffl daffl merged commit 75cd39e into master Jun 19, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@daffl daffl deleted the fixes-1034 branch Jun 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment