test and fix #1079 #1130

Merged
merged 1 commit into from Jul 24, 2014

Conversation

Projects
None yet
3 participants
@cherifGsoul
Member

cherifGsoul commented Jun 30, 2014

#1079 In some cases I saw even dataViewId in the URL

@cherifGsoul

This comment has been minimized.

Show comment
Hide comment
@cherifGsoul

cherifGsoul Jun 30, 2014

Member

the test fails in yui.html? an idea?

Member

cherifGsoul commented Jun 30, 2014

the test fails in yui.html? an idea?

@cherifGsoul

This comment has been minimized.

Show comment
Hide comment
@cherifGsoul

cherifGsoul Jul 2, 2014

Member

@matthewp could you tell me where is the error?

Member

cherifGsoul commented Jul 2, 2014

@matthewp could you tell me where is the error?

+ },
+ events:{
+ inserted:function(el,ev){
+ el.addClass('container');

This comment has been minimized.

@matthewp

matthewp Jul 2, 2014

Contributor

You should use can.addClass instead: http://canjs.com/docs/can.addClass.html

@matthewp

matthewp Jul 2, 2014

Contributor

You should use can.addClass instead: http://canjs.com/docs/can.addClass.html

@justinbmeyer justinbmeyer added the Bug label Jul 24, 2014

@justinbmeyer justinbmeyer added this to the 2.1.3 milestone Jul 24, 2014

+ tag:'x-app',
+ template:can.stache('Hello from CanJS'),
+ init:function(){
+ can.route.map(this.scope);

This comment has been minimized.

@justinbmeyer

justinbmeyer Jul 24, 2014

Contributor

Thanks for submitting this. Please try to avoid using extraneous parts of CanJS. can.route is unnecessary for a can.Component test.

@justinbmeyer

justinbmeyer Jul 24, 2014

Contributor

Thanks for submitting this. Please try to avoid using extraneous parts of CanJS. can.route is unnecessary for a can.Component test.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jul 24, 2014

Contributor

The test actually passes without the change the first time, until the hash has been updated.

I'm not sure what this is actually trying to test. Can you explain a bit more?

The existing check of: !twoWayBindings[camelized] should prevent what you are talking about without any extra work.

Contributor

justinbmeyer commented Jul 24, 2014

The test actually passes without the change the first time, until the hash has been updated.

I'm not sure what this is actually trying to test. Can you explain a bit more?

The existing check of: !twoWayBindings[camelized] should prevent what you are talking about without any extra work.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jul 24, 2014

Contributor

The test needs to be async to pick up the behavior. I understand the issue now.

Contributor

justinbmeyer commented Jul 24, 2014

The test needs to be async to pick up the behavior. I understand the issue now.

@justinbmeyer justinbmeyer merged commit 8bbb0c4 into canjs:master Jul 24, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@cherifGsoul

This comment has been minimized.

Show comment
Hide comment
@cherifGsoul

cherifGsoul Aug 5, 2014

Member

@justinbmeyer sorry I have been busy, thanks for the merge

Member

cherifGsoul commented Aug 5, 2014

@justinbmeyer sorry I have been busy, thanks for the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment