Fix @typedef name to be dot-separated. #1133

Merged
merged 1 commit into from Jul 23, 2014

Conversation

Projects
None yet
2 participants
@booc0mtaco
Contributor

booc0mtaco commented Jun 30, 2014

After reviewing other @ typedef definitions in other files, updated this one to use . instead of / for separators in the name.

This also fixes a warning in the dash docset generation script, which issues a warning when it encounters an invalid typedef name.

@@ -1,6 +1,6 @@
steal('can/util', function (can) {
/**
- * @typedef {{bind:function():*,unbind:function():*}} can/util/bind
+ * @typedef {{bind:function():*,unbind:function():*}} can.util.bind

This comment has been minimized.

@booc0mtaco

booc0mtaco Jun 30, 2014

Contributor

After reading http://javascriptmvc.com/docs/DocumentJS.tags.typedef.html, I am still unsure of what the TYPE section of a typedef means. Also, the links to TYPE and type expression result in 404.

@booc0mtaco

booc0mtaco Jun 30, 2014

Contributor

After reading http://javascriptmvc.com/docs/DocumentJS.tags.typedef.html, I am still unsure of what the TYPE section of a typedef means. Also, the links to TYPE and type expression result in 404.

@booc0mtaco

This comment has been minimized.

Show comment
Hide comment
@booc0mtaco

booc0mtaco Jun 30, 2014

Contributor

RE #1122

Contributor

booc0mtaco commented Jun 30, 2014

RE #1122

@booc0mtaco booc0mtaco added this to the 2.1.3 milestone Jul 23, 2014

justinbmeyer added a commit that referenced this pull request Jul 23, 2014

@justinbmeyer justinbmeyer merged commit 494e9f5 into master Jul 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@justinbmeyer justinbmeyer deleted the 1122-fix-bind-typedef branch Jul 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment