New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compute.read with a Map wrapped in a compute #1148

Merged
merged 1 commit into from Jul 10, 2014

Conversation

Projects
None yet
2 participants
@matthewp
Contributor

matthewp commented Jul 2, 2014

Previously if compute.read received a can.Map wrapped in a can.compute
it would attempt to call .attr against the compute itself. This is
because we were checking for prev to be a compute and if so getting
the value, but not setting the value on cur as well.

Fixes compute.read with a Map wrapped in a compute
Previously if compute.read received a can.Map wrapped in a can.compute
it would attempt to call `.attr` against the compute itself. This is
because we were checking for `prev` to be a compute and if so getting
the value, but not setting the value on `cur` as well.

@daffl daffl added this to the 2.1.3 milestone Jul 10, 2014

daffl added a commit that referenced this pull request Jul 10, 2014

Merge pull request #1148 from matthewp/compute-read-compute
Fixes compute.read with a Map wrapped in a compute

@daffl daffl merged commit 11bbf27 into canjs:master Jul 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@matthewp matthewp deleted the matthewp:compute-read-compute branch Jul 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment