Fix for #1132 #1150

Merged
merged 2 commits into from Jul 24, 2014

Conversation

Projects
None yet
2 participants
@asavoy
Contributor

asavoy commented Jul 3, 2014

Fixes SVG elements in stache templates, because the parser didn't support single character attributes.

asavoy added some commits Jul 3, 2014

Added failing test cases for #1132 - stache raises parser error on SV…
…G elements because parser doesn't support single-char attributes.
@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jul 23, 2014

Contributor

awesome. This will be merged soon.

Contributor

justinbmeyer commented Jul 23, 2014

awesome. This will be merged soon.

@justinbmeyer justinbmeyer added the Bug label Jul 23, 2014

@justinbmeyer justinbmeyer added this to the 2.1.3 milestone Jul 23, 2014

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jul 24, 2014

Contributor

I changed the test to avoid comparing innerHTML. IE capitalizes everything.

Contributor

justinbmeyer commented Jul 24, 2014

I changed the test to avoid comparing innerHTML. IE capitalizes everything.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jul 24, 2014

Contributor

And the real problem is single character attributes right?

Contributor

justinbmeyer commented Jul 24, 2014

And the real problem is single character attributes right?

@asavoy

This comment has been minimized.

Show comment
Hide comment
@asavoy

asavoy Jul 24, 2014

Contributor

@justinbmeyer Yep, single char attributes cause the parser error. Can only think of SVG elements that need it, and perhaps custom components.

Contributor

asavoy commented Jul 24, 2014

@justinbmeyer Yep, single char attributes cause the parser error. Can only think of SVG elements that need it, and perhaps custom components.

@justinbmeyer justinbmeyer merged commit e07db72 into canjs:master Jul 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@asavoy asavoy deleted the asavoy:1132-stache-svg-error branch Jul 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment