Fixed Mustache getHelper() so that it doesn't need second argument #1178

Merged
merged 1 commit into from Nov 5, 2014

Conversation

Projects
None yet
3 participants
@jondubois
Contributor

jondubois commented Jul 25, 2014

Mustache getHelper('helpername') would not work unless you supplied an empty Observe/Map as second argument.

Fixed Mustache getHelper() so that it doesn't need second argument
Mustache getHelper('helpername') would not work unless you supplied an empty Observe/Map as second argument.

@daffl daffl added this to the 2.1.4 milestone Jul 25, 2014

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Nov 3, 2014

Contributor

Assuming that this is for manually retrieving and calling helpers it looks ok I'll just have to add tests for it.

Contributor

daffl commented Nov 3, 2014

Assuming that this is for manually retrieving and calling helpers it looks ok I'll just have to add tests for it.

@m-mujica

This comment has been minimized.

Show comment
Hide comment
@m-mujica

m-mujica Nov 5, 2014

Contributor

@daffl I wrote a test for this https://github.com/bitovi/canjs/tree/test-1178, not sure how do you want to proceed, should I merge this PR in my branch?

Contributor

m-mujica commented Nov 5, 2014

@daffl I wrote a test for this https://github.com/bitovi/canjs/tree/test-1178, not sure how do you want to proceed, should I merge this PR in my branch?

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Nov 5, 2014

Contributor

Yes, merge the the remote branch in and make sure tests pass. Then we can merge this PR and then yours. Also, we probably want this for Stacheh as well?

Contributor

daffl commented Nov 5, 2014

Yes, merge the the remote branch in and make sure tests pass. Then we can merge this PR and then yours. Also, we probably want this for Stacheh as well?

daffl added a commit that referenced this pull request Nov 5, 2014

Merge pull request #1178 from jondubois/patch-1
Fixed Mustache getHelper() so that it doesn't need second argument

@daffl daffl merged commit 90360c3 into canjs:master Nov 5, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

daffl added a commit that referenced this pull request Nov 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment