New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the context correctly when an async compute has a length of 1 #1506

Merged
merged 1 commit into from Mar 10, 2015

Conversation

Projects
None yet
3 participants
@akagomez
Contributor

akagomez commented Mar 10, 2015

While updating our app to 2.2, @imjoshdean and I found a bug that caused a property's get method to have the wrong context when an argument was defined. Here's the first breaking test we were able to create: 2d0caf4

This PR fixes the bug and tests the specific aspect of can.compute that was causing the problem.

/cc @justinbmeyer

@daffl daffl added this to the 2.2.0 milestone Mar 10, 2015

justinbmeyer added a commit that referenced this pull request Mar 10, 2015

Merge pull request #1506 from bitovi/define-get-context-fix
Set the context correctly when an async compute has a length of 1

@justinbmeyer justinbmeyer merged commit 6fb12f5 into master Mar 10, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@justinbmeyer justinbmeyer deleted the define-get-context-fix branch Mar 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment