Cleans up computes and fixes deep .attr calls. #1696

Merged
merged 2 commits into from May 14, 2015

Conversation

Projects
None yet
2 participants
@justinbmeyer
Contributor

justinbmeyer commented May 14, 2015

I pull out most of the "computed" behavior into a compute/observe.js file: d2eabcc#diff-2ca5aa1b3dd10b09d026b426e2ebf950R1

Did a little inline docs too.

@justinbmeyer justinbmeyer changed the title from Cleans up computes to Cleans up computes and fixes deep .attr calls. May 14, 2015

@justinbmeyer justinbmeyer added the bug label May 14, 2015

@justinbmeyer justinbmeyer added this to the 2.2.6 milestone May 14, 2015

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl May 14, 2015

Contributor

What are the related issues? #1231, #1676 and #1657 right?

Contributor

daffl commented May 14, 2015

What are the related issues? #1231, #1676 and #1657 right?

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer May 14, 2015

Contributor

@daffl yes.

Contributor

justinbmeyer commented May 14, 2015

@daffl yes.

justinbmeyer added a commit that referenced this pull request May 14, 2015

Merge pull request #1696 from bitovi/compute-cleanup
Cleans up computes and fixes deep .attr calls.

@justinbmeyer justinbmeyer merged commit 435747a into master May 14, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@justinbmeyer justinbmeyer deleted the compute-cleanup branch May 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment