New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling define getters on map initialization #1704

Merged
merged 1 commit into from May 20, 2015

Conversation

Projects
None yet
1 participant
@daffl
Contributor

daffl commented May 20, 2015

This pull request makes sure that define getters are not called when initializing a new map. The change that caused this was related to #1526 but those tests now pass as well.

Also removes the attributes plugin tests (the plugin is deprecated) because of a conflict with define.

Fix initialization and calling define getters. Removing attributes pl…
…ugin tests because of conflict with define.

@daffl daffl added this to the 2.2.6 milestone May 20, 2015

@daffl daffl changed the title from Fix initialization and calling define getters on initialization to Fix calling define getters on map initialization May 20, 2015

daffl added a commit that referenced this pull request May 20, 2015

Merge pull request #1704 from bitovi/no-getter-init
Fix calling define getters on map initialization

@daffl daffl merged commit 6429628 into master May 20, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the no-getter-init branch May 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment