Makes scope.computeData listen to every observable in scope when value is not defined. #1709

Merged
merged 1 commit into from May 23, 2015

Conversation

Projects
None yet
2 participants
@justinbmeyer
Contributor

justinbmeyer commented May 23, 2015

For #579, this binds on everything until a specific value becomes defined.

The change was pretty simple. All I had to do was keep track of all "read" observables and re-apply them.

If this does slow down an app. There are three fixes:

  • leakScope: false
  • default undefined values to null
  • use ../ or ./

@justinbmeyer justinbmeyer added this to the 2.2.7 milestone May 23, 2015

@justinbmeyer justinbmeyer added the bug label May 23, 2015

justinbmeyer added a commit that referenced this pull request May 23, 2015

Merge pull request #1709 from bitovi/undefined-parent-579
Makes scope.computeData listen to every observable in scope when value is not defined.

@justinbmeyer justinbmeyer merged commit 83617f2 into master May 23, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@justinbmeyer justinbmeyer deleted the undefined-parent-579 branch May 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment