New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue when stealing mustache templates #175

Merged
merged 1 commit into from Nov 27, 2012

Conversation

Projects
None yet
2 participants
@Wizardum

Solve issue when stealing mustache templates.
Source: https://forum.javascriptmvc.com/topic/mustache-rendering-error

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Nov 27, 2012

Contributor

Thanks. This will also close #164. I'm wondering why this is necessary.

Contributor

daffl commented Nov 27, 2012

Thanks. This will also close #164. I'm wondering why this is necessary.

@Wizardum

This comment has been minimized.

Show comment
Hide comment
@Wizardum

Wizardum Nov 27, 2012

I checked and it seems that mustache.js was the only one that was returning a different object.
ejs.js, jaml.js, micro.js and tmpl.js were all returning a can object.

Whatever is receiving the template engine (I can't recall where I saw it) to compile the mustache templates, it expects an object as argument, and that object has a property called "Mustache", which is, in this case, the can object.

Regarding the thing about modules, I'm not sure how I can help with that though. I'm still trying to get how modules and AMD stuff works.

I checked and it seems that mustache.js was the only one that was returning a different object.
ejs.js, jaml.js, micro.js and tmpl.js were all returning a can object.

Whatever is receiving the template engine (I can't recall where I saw it) to compile the mustache templates, it expects an object as argument, and that object has a property called "Mustache", which is, in this case, the can object.

Regarding the thing about modules, I'm not sure how I can help with that though. I'm still trying to get how modules and AMD stuff works.

daffl added a commit that referenced this pull request Nov 27, 2012

Merge pull request #175 from Wizardum/master
Solve issue when stealing mustache templates

@daffl daffl merged commit 64e7e06 into canjs:master Nov 27, 2012

1 check passed

default The Travis build passed
Details
@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Nov 27, 2012

Contributor

Seems to work fine. Anybody who is using Steal + 1.1.1 need to change their Mustache object reference but it solves the problem. Thanks again!

Contributor

daffl commented Nov 27, 2012

Seems to work fine. Anybody who is using Steal + 1.1.1 need to change their Mustache object reference but it solves the problem. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment