New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass parent scope helpers to helper's options #1807

Closed
wants to merge 1 commit into
base: minor
from

Conversation

Projects
None yet
3 participants
@whitecolor
Contributor

whitecolor commented Jul 27, 2015

Pass parent scope helpers to helper's options. Related to this issue #1783

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jul 28, 2015

Contributor

This looks good to merge once travis passes.

Contributor

justinbmeyer commented Jul 28, 2015

This looks good to merge once travis passes.

@justinbmeyer justinbmeyer added this to the 2.3.0 milestone Jul 28, 2015

@whitecolor

This comment has been minimized.

Show comment
Hide comment
@whitecolor

whitecolor Jul 28, 2015

Contributor

The problem not with this PR?

Contributor

whitecolor commented Jul 28, 2015

The problem not with this PR?

@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Jul 28, 2015

Contributor

Looks related to a change I made to can-simple-dom, I'll pull it down and see what is going on.

Contributor

matthewp commented Jul 28, 2015

Looks related to a change I made to can-simple-dom, I'll pull it down and see what is going on.

@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Jul 28, 2015

Contributor

@whitecolor rebase with minor and the tests should all pass now.

Contributor

matthewp commented Jul 28, 2015

@whitecolor rebase with minor and the tests should all pass now.

@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Jul 29, 2015

Contributor

Closed by #1815

Contributor

matthewp commented Jul 29, 2015

Closed by #1815

@matthewp matthewp closed this Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment