New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override can.route's batch with other batching implementations #1882

Merged
merged 1 commit into from Sep 4, 2015

Conversation

Projects
None yet
3 participants
@joe-crick
Contributor

joe-crick commented Sep 3, 2015

Add ability to override can.route's batch with other batching implementations, like can.transaction

@joe-crick

This comment has been minimized.

Show comment
Hide comment
@joe-crick

joe-crick Sep 4, 2015

Contributor

Added test to show that the plugin works with can.route: canjs/can-interrupt@dbc6858

Contributor

joe-crick commented Sep 4, 2015

Added test to show that the plugin works with can.route: canjs/can-interrupt@dbc6858

@daffl daffl added this to the 2.3.0 milestone Sep 4, 2015

daffl added a commit that referenced this pull request Sep 4, 2015

Merge pull request #1882 from bitovi/1820-can-interupt-route-override
Add ability to override can.route's batch with other batching implementations

@daffl daffl merged commit 751071e into minor Sep 4, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the 1820-can-interupt-route-override branch Sep 4, 2015

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Sep 15, 2015

Contributor

Why is this here? Why would batching be needed to be overridden?

Contributor

justinbmeyer commented on route/route.js in 84047d0 Sep 15, 2015

Why is this here? Why would batching be needed to be overridden?

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Sep 15, 2015

Contributor

To me, it more seems like you want to overwrite setState ... or some smaller set of setState's behavior, but are making an inappropriately named hook called can.route.batch.

Contributor

justinbmeyer replied Sep 15, 2015

To me, it more seems like you want to overwrite setState ... or some smaller set of setState's behavior, but are making an inappropriately named hook called can.route.batch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment