New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed regression component control destructor #1886

Merged
merged 2 commits into from Sep 8, 2015

Conversation

Projects
None yet
2 participants
@gsmeets
Contributor

gsmeets commented Sep 7, 2015

This fixes a regression introduced in #1803 where the component's
control destroy method isn't called anymore when the component is
removed from the DOM.

Guido Smeets added some commits Sep 7, 2015

Guido Smeets
fixed regression component control destructor
This fixes a regression introduced in #1803 where the component's
control destroy method isn't called anymore when the component is
removed from the DOM.
Guido Smeets
fixed indentation
fixed indentation

daffl added a commit that referenced this pull request Sep 8, 2015

Merge pull request #1886 from gsmeets/fix-component-controller-not-de…
…stroyed

fixed regression component control destructor

@daffl daffl merged commit f49c3f6 into canjs:master Sep 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daffl daffl added this to the 2.2.8 milestone Sep 8, 2015

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Sep 8, 2015

Contributor

Thank you. I don't know how I missed that. I will get a 2.2.8 out shortly.

Contributor

daffl commented Sep 8, 2015

Thank you. I don't know how I missed that. I will get a 2.2.8 out shortly.

@gsmeets

This comment has been minimized.

Show comment
Hide comment
@gsmeets

gsmeets Sep 8, 2015

Contributor

That would be great. I just updated my build scenario to grab npm packages during build, instead of checking them into source control, so I'm tied to release packages at the moment.

Contributor

gsmeets commented Sep 8, 2015

That would be great. I just updated my build scenario to grab npm packages during build, instead of checking them into source control, so I'm tied to release packages at the moment.

@gsmeets gsmeets deleted the gsmeets:fix-component-controller-not-destroyed branch Sep 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment