Allow relative can-imports #2038

Merged
merged 2 commits into from Oct 29, 2015

Conversation

Projects
None yet
2 participants
@matthewp
Contributor

matthewp commented Oct 28, 2015

This fixes our can/view/stache/system plugin to normalize the dynamic
module names before adding them to System.bundle. This is needed because
steal-tools normalizes the bundle names and if the names are relative it
will throw an exception. Fixes #2037

Allow relative can-imports
This Fixes our can/view/stache/system plugin to normalize the dynamic
module names before adding them to System.bundle. This is needed because
steal-tools normalizes the bundle names and if the names are relative it
will throw an exception. Fixes #372
@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Oct 28, 2015

Contributor

Looking into why this is failing.

Contributor

matthewp commented Oct 28, 2015

Looking into why this is failing.

@matthewp matthewp added this to the 2.3.1 milestone Oct 28, 2015

@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Oct 28, 2015

Contributor

@daffl this is the PR i need in 2.3.1

Contributor

matthewp commented Oct 28, 2015

@daffl this is the PR i need in 2.3.1

daffl added a commit that referenced this pull request Oct 29, 2015

@daffl daffl merged commit 47cc61b into master Oct 29, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the dynamic-import-bundle branch Oct 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment