New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes exporting function work, but not pretty #2064

Merged
merged 3 commits into from Nov 9, 2015

Conversation

Projects
None yet
3 participants
@justinbmeyer
Contributor

justinbmeyer commented Nov 9, 2015

Closes #2051. Fix is to use key parsing the right way.

@justinbmeyer justinbmeyer added the bug label Nov 9, 2015

@justinbmeyer justinbmeyer added this to the 2.3.2 milestone Nov 9, 2015

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Nov 9, 2015

Contributor

@DesignByOnyx cc @matthewp looks like CI fail is due to can-simple-dom changes: https://travis-ci.org/canjs/canjs/jobs/90006250#L1998 . I thought these had been resolved?

Contributor

justinbmeyer commented Nov 9, 2015

@DesignByOnyx cc @matthewp looks like CI fail is due to can-simple-dom changes: https://travis-ci.org/canjs/canjs/jobs/90006250#L1998 . I thought these had been resolved?

@DesignByOnyx

This comment has been minimized.

Show comment
Hide comment
@DesignByOnyx

DesignByOnyx Nov 9, 2015

Contributor

This is needed first: #2063

Contributor

DesignByOnyx commented Nov 9, 2015

This is needed first: #2063

julia-allyce added a commit that referenced this pull request Nov 9, 2015

Merge pull request #2064 from canjs/component-method-export
makes exporting function work, but not pretty

@julia-allyce julia-allyce merged commit 60654c4 into master Nov 9, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the component-method-export branch Nov 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment