2183 update guides #2184

Merged
merged 1 commit into from Feb 3, 2016

Conversation

Projects
None yet
3 participants
@mjstahl
Member

mjstahl commented Jan 12, 2016

List of changes: https://docs.google.com/a/jupiterjs.com/spreadsheets/d/1pErqpcXVEaPmRFtpqidVBhx9ceP6Ky3HQlWYhbVz1ic/edit?usp=sharing

  • Go through each page and check text/code examples
  • Check/Update each JSBin
  • Update code archives with changes

@mjstahl mjstahl changed the title from [WIP] 2183 update guides to 2183 update guides Jan 12, 2016

@mjstahl

This comment has been minimized.

Show comment
Hide comment
@mjstahl

mjstahl Jan 13, 2016

Member

One JSBin needs to be changed to ensure consistency with routing in a template:

http://jsbin.com/surokag/edit?html,js,output

<a href="{{routeUrl page='restaurants'}}">

should be changed to:

<a href="{{ routeUrl(page='restaurants') }}">

And

<a href="{{routeUrl page='home'}}">

should be changed to:

<a href="{{ routeUrl(page='home') }}">
Member

mjstahl commented Jan 13, 2016

One JSBin needs to be changed to ensure consistency with routing in a template:

http://jsbin.com/surokag/edit?html,js,output

<a href="{{routeUrl page='restaurants'}}">

should be changed to:

<a href="{{ routeUrl(page='restaurants') }}">

And

<a href="{{routeUrl page='home'}}">

should be changed to:

<a href="{{ routeUrl(page='home') }}">
@@ -26,7 +26,7 @@
<li>
<label>
<input type="checkbox"
- (change)="{order.items.toggle this}"
+ ($change)="{order.items.toggle this}"

This comment has been minimized.

@mjstahl

mjstahl Jan 13, 2016

Member

should this be changed to

<input type="checkbox" ($change)="order.items.toggle(.)" ...
@mjstahl

mjstahl Jan 13, 2016

Member

should this be changed to

<input type="checkbox" ($change)="order.items.toggle(.)" ...
Fixes 2183 -- Updates the canjs.com Getting Started Guide
Stache Templates

View Models

Data Models and Fixtures

Loading States

Event Handling

Event Handling

Chapter 0 Example Code

Chapter 1 Example Code

Update canjs custom lib

Chapter 9 Example Code

Chapter 8 Example Code

Chapter 7 Code Examples

Corrections to Chapt 8 and 9

Chapter 6 Example Code

Chapter 5 Example Code

Chapter 4 Example Code

Chapter 3 Example Code

Chapter 2 Example Code

Chapter 1 Example Code

Chapter 0 Example Code

Correct routeUrl call syntax

Fix missed order template expressions
@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jan 21, 2016

Contributor

This seems like a lot of additions. Should that still live in our main repository?

Contributor

daffl commented Jan 21, 2016

This seems like a lot of additions. Should that still live in our main repository?

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jan 21, 2016

Contributor

Yes. It was worse when it didn't.

Sent from my iPhone

On Jan 21, 2016, at 9:47 AM, David Luecke notifications@github.com wrote:

This seems like a lot of additions. Should that still live in our main repository?


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Jan 21, 2016

Yes. It was worse when it didn't.

Sent from my iPhone

On Jan 21, 2016, at 9:47 AM, David Luecke notifications@github.com wrote:

This seems like a lot of additions. Should that still live in our main repository?


Reply to this email directly or view it on GitHub.

@justinbmeyer justinbmeyer self-assigned this Feb 2, 2016

@justinbmeyer justinbmeyer added this to the 2.3.14 milestone Feb 2, 2016

@justinbmeyer justinbmeyer merged commit 48540f1 into master Feb 3, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@justinbmeyer justinbmeyer deleted the 2183-update-guides branch Feb 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment