New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `map.attr` with empty string. #2219

Merged
merged 1 commit into from Feb 3, 2016

Conversation

Projects
None yet
2 participants
@m-mujica
Contributor

m-mujica commented Jan 28, 2016

It was returning the collection of all of the properties of the Map instance instead of the actual value set to the empty string key.

failed

Fix `.attr` with empty string.
It was returning the collection of all of the properties of the
Map instance instead of the actual value set to the empty string key.

daffl added a commit that referenced this pull request Feb 3, 2016

Merge pull request #2219 from canjs/attr-empty-string
Fix `map.attr` with empty string.

@daffl daffl merged commit 1756a06 into master Feb 3, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the attr-empty-string branch Feb 3, 2016

@daffl daffl added this to the 2.3.14 milestone Feb 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment