New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a CanSimpleDocument constructor #2312

Merged
merged 1 commit into from Mar 8, 2016

Conversation

Projects
None yet
2 participants
@matthewp
Contributor

matthewp commented Mar 7, 2016

This is needed so you can do: new document.constructor() which will
set up both the parser and serializer behavior. Currently in can-ssr we
are setting this up ourselves, which is gross:
https://github.com/canjs/can-ssr/blob/c5e2ec1be5cc28e1d6482b986f67c068dc4cc5b9/lib/index.js#L58

Needed for donejs/done-ssr#128

Create a CanSimpleDocument constructor
This is needed so you can do: `new document.constructor()` which will
set up both the parser and serializer behavior. Currently in can-ssr we
are setting this up ourselves, which is gross:
https://github.com/canjs/can-ssr/blob/c5e2ec1be5cc28e1d6482b986f67c068dc4cc5b9/lib/index.js#L58

@matthewp matthewp added this to the 2.3.20 milestone Mar 7, 2016

daffl added a commit that referenced this pull request Mar 8, 2016

Merge pull request #2312 from canjs/cansimpledocument
Create a CanSimpleDocument constructor

@daffl daffl merged commit e337bc9 into master Mar 8, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the cansimpledocument branch Mar 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment