New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support svg camelCase elements. #2420

Merged
merged 1 commit into from Aug 10, 2016

Conversation

Projects
None yet
3 participants
@marshallswain
Member

marshallswain commented Jun 16, 2016

This adds another map for all of the svg tags that require camelCasing. Taken from this page: https://developer.mozilla.org/en-US/docs/Web/SVG/Element

Also includes a passing test for radialGradient.

related to canjs/canjs#2418

@marshallswain marshallswain self-assigned this Jun 16, 2016

@marshallswain

This comment has been minimized.

Show comment
Hide comment
@marshallswain

marshallswain Jun 17, 2016

Member

This same fix has already been merged into the v3.0 repo here: canjs/can-view-parser#9

Member

marshallswain commented Jun 17, 2016

This same fix has already been merged into the v3.0 repo here: canjs/can-view-parser#9

@pYr0x

This comment has been minimized.

Show comment
Hide comment
@pYr0x

pYr0x Jul 12, 2016

so we can set this for the legacy release of 2.3.X ?

pYr0x commented Jul 12, 2016

so we can set this for the legacy release of 2.3.X ?

@pYr0x pYr0x added this to the 2.3.25 milestone Jul 12, 2016

@justinbmeyer justinbmeyer merged commit 0505b2c into master Aug 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@justinbmeyer justinbmeyer removed the review label Aug 10, 2016

@daffl daffl deleted the support-svg-tags branch Sep 1, 2016

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Sep 2, 2016

Contributor

@marshallswain why do we have to even track the caseMatters? Could we just stop toLowerCase()-ing what we get?

Contributor

justinbmeyer commented Sep 2, 2016

@marshallswain why do we have to even track the caseMatters? Could we just stop toLowerCase()-ing what we get?

@marshallswain

This comment has been minimized.

Show comment
Hide comment
@marshallswain

marshallswain Sep 2, 2016

Member

That makes sense to me. I don't know why we are lower casing in the first
place.

On Fri, Sep 2, 2016 at 2:17 PM Justin Meyer notifications@github.com
wrote:

@marshallswain https://github.com/marshallswain why do we have to even
track the caseMatters? Could we just stop toLowerCase()-ing what we get?


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#2420 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAH3WUxNSY-vhM84Iv6_l3Cpf7nApEywks5qmIRUgaJpZM4I3mmv
.

Member

marshallswain commented Sep 2, 2016

That makes sense to me. I don't know why we are lower casing in the first
place.

On Fri, Sep 2, 2016 at 2:17 PM Justin Meyer notifications@github.com
wrote:

@marshallswain https://github.com/marshallswain why do we have to even
track the caseMatters? Could we just stop toLowerCase()-ing what we get?


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#2420 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAH3WUxNSY-vhM84Iv6_l3Cpf7nApEywks5qmIRUgaJpZM4I3mmv
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment