New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item.List splice method does not convert inserted elements to Item type #253

Merged
merged 1 commit into from Feb 26, 2013

Conversation

Projects
None yet
2 participants
@daffl
Contributor

daffl commented Feb 25, 2013

New elements inserted List of Observe inheritor with splice method is not converted to base class.

push and unshift do the conversion.

http://jsfiddle.net/qYdwR/646/

@whitecolor

This comment has been minimized.

Show comment
Hide comment
@whitecolor

whitecolor Jan 26, 2013

Contributor

Have you looked at fiddle?

Contributor

whitecolor commented Jan 26, 2013

Have you looked at fiddle?

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Feb 20, 2013

Contributor

Yep. And seeing the problem. Will fix for 1.1.5 which should be out around the middle/end of March.

Contributor

daffl commented Feb 20, 2013

Yep. And seeing the problem. Will fix for 1.1.5 which should be out around the middle/end of March.

@ghost ghost assigned daffl Feb 25, 2013

daffl added a commit that referenced this pull request Feb 26, 2013

Merge pull request #253 from bitovi/list-splice-convert-253
Item.List splice method does not convert inserted elements to Item type

@daffl daffl merged commit 499036c into master Feb 26, 2013

1 check passed

default The Travis build passed
Details

@daffl daffl deleted the list-splice-convert-253 branch Feb 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment