New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.view with Deferreds doesn't pass failures #276

Merged
merged 2 commits into from Feb 24, 2013

Conversation

Projects
None yet
1 participant
@daffl
Contributor

daffl commented Feb 23, 2013

When a deferred passed to can.view data fails the view rendering deferred doesn't fail:

can.view('myview', {
  data: MyModel.findAll()
}).then(function(fragment, data) {

}, function() {
  // Fail callback gets never called if MyModel.findAll fails
});

daffl added a commit that referenced this pull request Feb 24, 2013

Merge pull request #276 from bitovi/view-deferred-fail-276
can.view with Deferreds doesn't pass failures

@daffl daffl merged commit 4785c00 into master Feb 24, 2013

1 check passed

default The Travis build passed
Details

@daffl daffl deleted the view-deferred-fail-276 branch Feb 24, 2013

@ghost ghost assigned daffl Feb 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment