New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.compute evaluations for the default Mustache handlers #292

Merged
merged 3 commits into from Mar 7, 2013

Conversation

Projects
None yet
2 participants
@bmomberger-reciprocity
Contributor

bmomberger-reciprocity commented Feb 27, 2013

True/false evaluations fail if a can.compute gets passed to if/else. Ensure they are eval'ed before testing on their values.

@bmomberger-reciprocity

This comment has been minimized.

Show comment
Hide comment
@bmomberger-reciprocity

bmomberger-reciprocity Feb 27, 2013

Contributor

Note that for {{#with}} to be demonstrable, I also had to add a computed check in Mustache.get, since the context object might be a compute. Anyway, tests are in for this change.

Contributor

bmomberger-reciprocity commented Feb 27, 2013

Note that for {{#with}} to be demonstrable, I also had to add a computed check in Mustache.get, since the context object might be a compute. Anyway, tests are in for this change.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 7, 2013

Contributor

👍

Contributor

daffl commented Mar 7, 2013

👍

daffl added a commit that referenced this pull request Mar 7, 2013

Merge pull request #292 from bmomberger-reciprocity/computes_for_defa…
…ult_helpers

can.compute evaluations for the default Mustache handlers

@daffl daffl merged commit 5ea5622 into canjs:master Mar 7, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment