New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model override should work for create and update not just findone and findall #301

Merged
merged 5 commits into from May 2, 2013

Conversation

Projects
None yet
3 participants
@ccummings
Contributor

ccummings commented May 1, 2013

When I override the model structure, this works fine for findone and findall, however it does not apply to create and update which I then have to manually process when the newly created model instance is returned.

ie. I create an object where the object is nested {note: {id:4}}
When the response on successful create comes back it is also nested by my overridden model is not applied.

In case this is relevant, my experience is with the MooTools version of canjs.

@tracer99

This comment has been minimized.

Show comment
Hide comment
@tracer99

tracer99 Mar 5, 2013

Contributor

Conversation in Forums about this issue: https://forum.javascriptmvc.com/#Topic/32525000001090143

Contributor

tracer99 commented Mar 5, 2013

Conversation in Forums about this issue: https://forum.javascriptmvc.com/#Topic/32525000001090143

ccummings added a commit that referenced this pull request May 2, 2013

Merge pull request #301 from bitovi/issue-301
model override should work for create and update not just findone and findall

@ccummings ccummings merged commit 59a74a9 into master May 2, 2013

1 check passed

default The Travis build passed
Details

@ccummings ccummings deleted the issue-301 branch May 2, 2013

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Oct 24, 2013

Contributor

This breaks some other things, specifically around what goes in the model store. The model function does not simply "unbox" the response data, it put things in the store. I'm going to fix this.

Contributor

justinbmeyer commented Oct 24, 2013

This breaks some other things, specifically around what goes in the model store. The model function does not simply "unbox" the response data, it put things in the store. I'm going to fix this.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Nov 23, 2013

Contributor

This rears it's ugly head again with #560 and #561.

This needs to be fixed, but might require some breaking API changes.

Contributor

justinbmeyer commented Nov 23, 2013

This rears it's ugly head again with #560 and #561.

This needs to be fixed, but might require some breaking API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment