New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute startBatch callbacks #315

Merged
merged 3 commits into from Mar 15, 2013

Conversation

Projects
None yet
2 participants
@thecountofzero
Contributor

thecountofzero commented Mar 14, 2013

The callbacks passed in to startBatch were not being called.

Updated the existing startBatch/stopBatch test. There was an assertion in there for callbacks, but since the callback wasn't being executed, the assertion was not being run. I updated that test to expect the total number of assertions.

I also added a small test that makes sure the callback is executed

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 14, 2013

Contributor

The build failed, I think in your new tests. Could you merge with latest master and re-run the full test suite (can/test/index.html) to verify? Thanks :)

Contributor

daffl commented Mar 14, 2013

The build failed, I think in your new tests. Could you merge with latest master and re-run the full test suite (can/test/index.html) to verify? Thanks :)

@thecountofzero

This comment has been minimized.

Show comment
Hide comment
@thecountofzero

thecountofzero Mar 14, 2013

Contributor

I had the wrong expected assertions count. I forgot I removed a change to the observe before committing the test and never decremented the expected assertions count.

Should be good now.

Contributor

thecountofzero commented Mar 14, 2013

I had the wrong expected assertions count. I forgot I removed a change to the observe before committing the test and never decremented the expected assertions count.

Should be good now.

daffl added a commit that referenced this pull request Mar 15, 2013

@daffl daffl merged commit 22f4f67 into canjs:master Mar 15, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment