New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing error that occurs when an item in an Observe.List contains a comp... #419

Merged
merged 2 commits into from Jun 10, 2013

Conversation

Projects
None yet
2 participants
@ccummings
Contributor

ccummings commented Jun 4, 2013

...ute and is removed

If an Observe.List item contains a compute that does not have any bindings, removing that item from the list results in a JS error in compute.js

This occurs when the compute does not have any bindings, so on is never called, leaving computedData === undefined.

Fix is to check that computedData is truthy before calling teardown()

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jun 7, 2013

Contributor

Can you quickly merge latest master (which has CI fixed) into your feature branch and push to re-run the tests? Once they passed this is good to merge I think.

Contributor

daffl commented Jun 7, 2013

Can you quickly merge latest master (which has CI fixed) into your feature branch and push to re-run the tests? Once they passed this is good to merge I think.

daffl added a commit that referenced this pull request Jun 10, 2013

Merge pull request #419 from bitovi/computes-in-lists
Fixing error that occurs when an item in an Observe.List contains a comp...

@daffl daffl merged commit 1ef88af into master Jun 10, 2013

@daffl daffl deleted the computes-in-lists branch Jun 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment