Use .attr() when evaluating errors in validations #437

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@airhadoken
Contributor

airhadoken commented Jun 20, 2013

#410 in pull request form

In order to make it possible to bind a can.compute to error evaluations, switch the [attr] access of attributes to .attr(attr)

I've been using this for a few weeks on reciprocity/ggrc-core and it seems to be working out without unintended side effects.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jul 17, 2013

Contributor

I think that makes total sense. Lets get it into 1.1.7. Does this need a test?

Contributor

daffl commented Jul 17, 2013

I think that makes total sense. Lets get it into 1.1.7. Does this need a test?

@daffl daffl closed this in 8db2da5 Jul 19, 2013

@bmomberger-reciprocity

This comment has been minimized.

Show comment
Hide comment
@bmomberger-reciprocity

bmomberger-reciprocity Jul 19, 2013

Contributor

👍 thanks for constructing the test.

Contributor

bmomberger-reciprocity commented Jul 19, 2013

👍 thanks for constructing the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment