Catch only exceptions thrown by model[func]() (fix #454 and re #384) #455

Merged
merged 1 commit into from Aug 30, 2013

Conversation

Projects
None yet
3 participants
@scorphus
Contributor

scorphus commented Jul 27, 2013

Catch only exceptions thrown by modelfunc, and not by d.resolvWith(). The Deferred is resolved only if modelfunc succeeds.

/re #454 and #384
/cc @daffl and @thecountofzero thanks for reviewing any comments are welcome

Catch only exceptions thrown by model[func]() (fix #454 and re #384)
The Deferred is resolved only if model[func]() succeeds.
@thecountofzero

This comment has been minimized.

Show comment
Hide comment
@thecountofzero

thecountofzero Jul 28, 2013

Sorry for the delay. Just applied the changes and it no longer seems to be swallowing errors.

Just wondering if this fix will result in any issue where having "d.resolveWith(d, args)" inside the try would have prevented?

Sorry for the delay. Just applied the changes and it no longer seems to be swallowing errors.

Just wondering if this fix will result in any issue where having "d.resolveWith(d, args)" inside the try would have prevented?

daffl added a commit that referenced this pull request Aug 30, 2013

Merge pull request #455 from scorphus/issue-454-canjs-swallowing-errors
Catch only exceptions thrown by model[func]() (fix #454 and re #384)

@daffl daffl merged commit 38a9ab8 into canjs:master Aug 30, 2013

1 check passed

default The Travis CI build passed
Details

@scorphus scorphus deleted the scorphus:issue-454-canjs-swallowing-errors branch Sep 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment