New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower support, multiple jQuery versions #529

Merged
merged 7 commits into from Nov 26, 2013

Conversation

Projects
None yet
2 participants
@daffl
Contributor

daffl commented Nov 5, 2013

This pull request uses Bower to install Qunit, jQuery and Zepto and introduces a jQuery legacy (1.10) configuration (as mentioned in #526) and removes supported libraries from being checked directly into the repository.

bower install will run as an NPM post-install script. Although this is considered to be an anti pattern this should be ok here as NPM is only used for development. Re-run npm install after updating from this PR to get the bower components.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Nov 6, 2013

Contributor

Why bower? Would npm be enough?

Sent from my iPhone

On Nov 5, 2013, at 5:26 PM, David Luecke notifications@github.com wrote:

This pull request uses Bower to install Qunit, jQuery and Zepto and introduces a jQuery legacy (1.10) configuration (as mentioned in #526) and removes supported libraries from being checked directly into the repository.

bower install will run as an NPM post-install script. Although this is considered to be an anti pattern this should be ok here as NPM is only used for development. Re-run npm install after updating from this PR to get the bower components.

You can merge this Pull Request by running

git pull https://github.com/bitovi/canjs bower-multi-jquery
Or view, comment on, or merge it at:

#529

Commit Summary

Changing QUnit and references to Bower component.
Adding bower.json for client side dependencies.
Merge branch 'master' of github.com:bitovi/canjs
Moving jQuery and Zepto to Bower components. Adding jQuery legacy (1.X).
Removing old Mootools version and Bower dependency (since it is pretty useless).
File Changes

M .gitignore (1)
A bower.json (18)
M builder.json (25)
M component/test.html (4)
M compute/test.html (4)
M construct/proxy/test.html (4)
M construct/super/test.html (4)
M construct/test.html (4)
M control/modifier/qunit.html (4)
M control/plugin/test.html (4)
M control/route/test.html (4)
M control/test.html (4)
M control/view/qunit.html (4)
D lib/jquery.1.9.1.js (9600)
D lib/mootools-core-1.4.3.js (5905)
D lib/qunit/qunit.css (244)
D lib/qunit/qunit.js (2152)
M lib/stealconfig.js (111)
D lib/zepto.1.0.js (1565)
D lib/zepto.1.0rc1.js (1355)
M list/test.html (4)
M map/attributes/test.html (4)
M map/backup/test.html (4)
M map/delegate/test.html (4)
M map/setter/test.html (4)
M map/sort/test.html (4)
M map/test.html (4)
M map/validations/test.html (4)
M model/cached/qunit.html (4)
M model/queue/qunit.html (4)
M model/test.html (4)
M observe/test.html (4)
M package.json (84)
M route/pushstate/test.html (4)
M route/test.html (4)
M test/amd/dojo.html (4)
A test/amd/jquery-legacy.html (156)
M test/amd/jquery.html (6)
M test/amd/mootools.html (4)
M test/amd/yui.html (4)
M test/amd/zepto.html (6)
D test/build/dojo.html (53)
D test/build/index.html (55)
D test/build/jquery.html (57)
D test/build/mootools.html (53)
D test/build/yui.html (53)
D test/build/zepto.html (53)
M test/dist/dojo.html (4)
A test/dist/jquery-legacy.html (91)
M test/dist/jquery.html (6)
M test/dist/mootools.html (4)
M test/dist/yui.html (4)
M test/dist/zepto.html (6)
M test/dojo.html (4)
A test/jquery-legacy.html (83)
M test/jquery.html (6)
M test/mootools.html (4)
M test/templates/configuration-amd.html.ejs (4)
M test/templates/configuration-dist.html.ejs (4)
M test/templates/configuration.html.ejs (4)
M test/templates/test.html.ejs (4)
M test/yui.html (4)
M test/zepto.html (6)
M util/event/test.html (4)
M util/string/qunit.html (2)
M view/bindings/test.html (4)
M view/ejs/test.html (4)
M view/live/test.html (4)
M view/modifiers/test.html (4)
M view/mustache/test.html (4)
M view/scope/test.html (4)
M view/test.html (4)
Patch Links:

https://github.com/bitovi/canjs/pull/529.patch
https://github.com/bitovi/canjs/pull/529.diff

Contributor

justinbmeyer commented Nov 6, 2013

Why bower? Would npm be enough?

Sent from my iPhone

On Nov 5, 2013, at 5:26 PM, David Luecke notifications@github.com wrote:

This pull request uses Bower to install Qunit, jQuery and Zepto and introduces a jQuery legacy (1.10) configuration (as mentioned in #526) and removes supported libraries from being checked directly into the repository.

bower install will run as an NPM post-install script. Although this is considered to be an anti pattern this should be ok here as NPM is only used for development. Re-run npm install after updating from this PR to get the bower components.

You can merge this Pull Request by running

git pull https://github.com/bitovi/canjs bower-multi-jquery
Or view, comment on, or merge it at:

#529

Commit Summary

Changing QUnit and references to Bower component.
Adding bower.json for client side dependencies.
Merge branch 'master' of github.com:bitovi/canjs
Moving jQuery and Zepto to Bower components. Adding jQuery legacy (1.X).
Removing old Mootools version and Bower dependency (since it is pretty useless).
File Changes

M .gitignore (1)
A bower.json (18)
M builder.json (25)
M component/test.html (4)
M compute/test.html (4)
M construct/proxy/test.html (4)
M construct/super/test.html (4)
M construct/test.html (4)
M control/modifier/qunit.html (4)
M control/plugin/test.html (4)
M control/route/test.html (4)
M control/test.html (4)
M control/view/qunit.html (4)
D lib/jquery.1.9.1.js (9600)
D lib/mootools-core-1.4.3.js (5905)
D lib/qunit/qunit.css (244)
D lib/qunit/qunit.js (2152)
M lib/stealconfig.js (111)
D lib/zepto.1.0.js (1565)
D lib/zepto.1.0rc1.js (1355)
M list/test.html (4)
M map/attributes/test.html (4)
M map/backup/test.html (4)
M map/delegate/test.html (4)
M map/setter/test.html (4)
M map/sort/test.html (4)
M map/test.html (4)
M map/validations/test.html (4)
M model/cached/qunit.html (4)
M model/queue/qunit.html (4)
M model/test.html (4)
M observe/test.html (4)
M package.json (84)
M route/pushstate/test.html (4)
M route/test.html (4)
M test/amd/dojo.html (4)
A test/amd/jquery-legacy.html (156)
M test/amd/jquery.html (6)
M test/amd/mootools.html (4)
M test/amd/yui.html (4)
M test/amd/zepto.html (6)
D test/build/dojo.html (53)
D test/build/index.html (55)
D test/build/jquery.html (57)
D test/build/mootools.html (53)
D test/build/yui.html (53)
D test/build/zepto.html (53)
M test/dist/dojo.html (4)
A test/dist/jquery-legacy.html (91)
M test/dist/jquery.html (6)
M test/dist/mootools.html (4)
M test/dist/yui.html (4)
M test/dist/zepto.html (6)
M test/dojo.html (4)
A test/jquery-legacy.html (83)
M test/jquery.html (6)
M test/mootools.html (4)
M test/templates/configuration-amd.html.ejs (4)
M test/templates/configuration-dist.html.ejs (4)
M test/templates/configuration.html.ejs (4)
M test/templates/test.html.ejs (4)
M test/yui.html (4)
M test/zepto.html (6)
M util/event/test.html (4)
M util/string/qunit.html (2)
M view/bindings/test.html (4)
M view/ejs/test.html (4)
M view/live/test.html (4)
M view/modifiers/test.html (4)
M view/mustache/test.html (4)
M view/scope/test.html (4)
M view/test.html (4)
Patch Links:

https://github.com/bitovi/canjs/pull/529.patch
https://github.com/bitovi/canjs/pull/529.diff

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Nov 6, 2013

Contributor

I'm pretty positive NPM doesn't have packaged versions for jQuery, QUnit or Zepto (at least properly maintained). And since NPM expects a package.json and CommonJS modules you can't just pull the repositories in (which would be nice in our case). Bower seems like the best choice (although it seems to be missing packages for proper Mootools, YUI and Dojo versions).

Contributor

daffl commented Nov 6, 2013

I'm pretty positive NPM doesn't have packaged versions for jQuery, QUnit or Zepto (at least properly maintained). And since NPM expects a package.json and CommonJS modules you can't just pull the repositories in (which would be nice in our case). Bower seems like the best choice (although it seems to be missing packages for proper Mootools, YUI and Dojo versions).

daffl added a commit that referenced this pull request Nov 26, 2013

Merge pull request #529 from bitovi/bower-multi-jquery
Bower support, multiple jQuery versions

@daffl daffl merged commit 261e7c4 into master Nov 26, 2013

1 check passed

default The Travis CI build passed
Details

@daffl daffl deleted the bower-multi-jquery branch Nov 26, 2013

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 7, 2013

Contributor

@daffl you broke this kinda stuff

Contributor

justinbmeyer commented on list/test.html in 00ef083 Dec 7, 2013

@daffl you broke this kinda stuff

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 7, 2013

Contributor

Also, this won't work offline. I traditionally fix a lot of bugs while I'm flying.

Contributor

justinbmeyer replied Dec 7, 2013

Also, this won't work offline. I traditionally fix a lot of bugs while I'm flying.

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Dec 8, 2013

Contributor

Yeah, Webstorm did some crazy weird refactoring with those CDN URLs. #446 fixes this and adds all those pages to CI as well. I just merged it in. Maybe we should use Bower already at least for QUnit. That would work offline and we'd avoid checking in unnecessary dependencies.

Contributor

daffl replied Dec 8, 2013

Yeah, Webstorm did some crazy weird refactoring with those CDN URLs. #446 fixes this and adds all those pages to CI as well. I just merged it in. Maybe we should use Bower already at least for QUnit. That would work offline and we'd avoid checking in unnecessary dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment