Functions globally defined when it shouldn't be #604

Merged
merged 2 commits into from Dec 11, 2013

Conversation

Projects
None yet
3 participants
@matthewp
Contributor

matthewp commented Dec 10, 2013

The functions updateList and teardownList are meant to be local variables in this context but are added to the window due to not being declared. Causes hard to track down issues when you have multiple lists being bound at the time same time.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 10, 2013

Contributor

@matthewp can you add more details?

Contributor

justinbmeyer commented Dec 10, 2013

@matthewp can you add more details?

@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Dec 10, 2013

Contributor

@justinbmeyer added an explanation.

Contributor

matthewp commented Dec 10, 2013

@justinbmeyer added an explanation.

Fixes variables attached to the window.
This fixes a few instances where variables were being attached to the window that are meant to be used only locally.

daffl added a commit that referenced this pull request Dec 11, 2013

Merge pull request #604 from matthewp/undeclared-funs
Functions defined without being declared.

@daffl daffl merged commit 5c87b08 into canjs:master Dec 11, 2013

1 check passed

default The Travis CI build passed
Details

daffl added a commit that referenced this pull request Dec 19, 2013

@daffl daffl referenced this pull request Dec 19, 2013

Merged

Adding tests for #604 #621

daffl added a commit that referenced this pull request Dec 19, 2013

justinbmeyer added a commit that referenced this pull request Jan 23, 2014

andykant added a commit that referenced this pull request Jan 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment