New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary fixed mustache index calculation with simple can.List when remove first item of list #613

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@yusufsafak
Contributor

yusufsafak commented Dec 16, 2013

And when you look console log after removing first item,you will see removed item appears in log and two times wrong index calculation. I could not find the bug but I think it is related to length event.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 18, 2013

Contributor

Thanks. Will checkout.

Contributor

justinbmeyer commented Dec 18, 2013

Thanks. Will checkout.

@yusufsafak

This comment has been minimized.

Show comment
Hide comment
@yusufsafak

yusufsafak Dec 19, 2013

Contributor

I checked it again and I found that can.view.lists function can't update key property of item in index function. It causes wrong fromIndex.

Contributor

yusufsafak commented Dec 19, 2013

I checked it again and I found that can.view.lists function can't update key property of item in index function. It causes wrong fromIndex.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 19, 2013

Contributor

#620 includes a fix and your test. Thanks for the test!

Contributor

justinbmeyer commented Dec 19, 2013

#620 includes a fix and your test. Thanks for the test!

@yusufsafak

This comment has been minimized.

Show comment
Hide comment
@yusufsafak

yusufsafak Dec 21, 2013

Contributor

Thanks

Contributor

yusufsafak commented Dec 21, 2013

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment