Node lists rewrite #615

Merged
merged 7 commits into from Dec 19, 2013

Conversation

Projects
None yet
2 participants
@justinbmeyer
Contributor

justinbmeyer commented Dec 18, 2013

This

  • Fixes #605 and adds a test for it
  • Makes some substantial changes to how nodeLists operates
  • Changes the location of node_lists.js
  • Includes a lot of improved inline documentation.

A nodeList now knows about its parent and child node lists so it is able to update them more effectively.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Dec 18, 2013

Contributor

Why a new PR? #614 was up to date, too?

Contributor

daffl commented Dec 18, 2013

Why a new PR? #614 was up to date, too?

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 18, 2013

Contributor

I didn't include deadeab and I wanted to make sure you didn't merge while I was still working on it.

Contributor

justinbmeyer commented Dec 18, 2013

I didn't include deadeab and I wanted to make sure you didn't merge while I was still working on it.

daffl added a commit that referenced this pull request Dec 19, 2013

@daffl daffl merged commit 7bbf460 into master Dec 19, 2013

1 check passed

default The Travis CI build passed
Details

@daffl daffl deleted the nodeLists-rewrite branch Dec 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment