New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.4 test fixes #625

Merged
merged 6 commits into from Dec 23, 2013

Conversation

Projects
None yet
2 participants
@daffl
Contributor

daffl commented Dec 20, 2013

Fixes for all tests cross-browser

IE 8 + jQuery

  • can/view: create a template before the custom element works with slash and colon
  • can/view: loaded live element test
  • can/view: content within non-component tags gets rendered with context
  • can/view/mustache: html comments must not break mustache scanner
  • can/view/live: attributes - this is actually a problem with using splice within can.List.
  • can/map/attributes: Maximum call stack size exceeded with global models (#476)
  • - Check other libraries?
@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 22, 2013

Contributor

A better way of doing this will be to replace this with can.proxy(Character.models, Character).

Contributor

justinbmeyer commented on map/attributes/attributes_test.js in c705275 Dec 22, 2013

A better way of doing this will be to replace this with can.proxy(Character.models, Character).

}
}, {});
window.Game = can.Model.extend({
attributes: {
characters: 'Character.models'
characters: function(){

This comment has been minimized.

@daffl

daffl Dec 23, 2013

Contributor

Btw, now you can also use characters: Character (http://canjs.com/docs/can.Map.attributes.html#section_Associations). Using either way won't really test the issue however, because only the old way seems to cause a recursive error (most likely because it is being called differently).

@daffl

daffl Dec 23, 2013

Contributor

Btw, now you can also use characters: Character (http://canjs.com/docs/can.Map.attributes.html#section_Associations). Using either way won't really test the issue however, because only the old way seems to cause a recursive error (most likely because it is being called differently).

daffl added a commit that referenced this pull request Dec 23, 2013

@daffl daffl merged commit c9181cf into master Dec 23, 2013

1 check passed

default The Travis CI build passed
Details

@daffl daffl deleted the test-fixes-2.0.4 branch Dec 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment