New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#each on undefined attributes not working anymore in 2.0.4 #629

Merged
merged 2 commits into from Jan 7, 2014

Conversation

Projects
None yet
3 participants
@andykant
Contributor

andykant commented Jan 3, 2014

dfc88b4 introduced several fixes for #each but broke iterating over a previously undefined list.

Fiddle: http://jsfiddle.net/G54Vz/

This is a regression issue and worked in 2.0.3: http://jsfiddle.net/G54Vz/1/

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 24, 2013

Contributor

Why did the test not catch it?

Sent from my iPhone

On Dec 23, 2013, at 5:55 PM, David Luecke notifications@github.com wrote:

dfc88b4 introduced several fixes for #each but broke iterating over a previously undefined list.

Fiddle: http://jsfiddle.net/G54Vz/

This is a regression issue and worked in 2.0.3: http://jsfiddle.net/G54Vz/1/


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Dec 24, 2013

Why did the test not catch it?

Sent from my iPhone

On Dec 23, 2013, at 5:55 PM, David Luecke notifications@github.com wrote:

dfc88b4 introduced several fixes for #each but broke iterating over a previously undefined list.

Fiddle: http://jsfiddle.net/G54Vz/

This is a regression issue and worked in 2.0.3: http://jsfiddle.net/G54Vz/1/


Reply to this email directly or view it on GitHub.

@ghost ghost assigned andykant Jan 2, 2014

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jan 7, 2014

Contributor

Hey @andykant can you merge this branch with latest master? Looks like one of the other PRs caused a conflict.

Also, there wasn't a test for this specific issue before. Looks like this case never got really tested before.

Contributor

daffl commented Jan 7, 2014

Hey @andykant can you merge this branch with latest master? Looks like one of the other PRs caused a conflict.

Also, there wasn't a test for this specific issue before. Looks like this case never got really tested before.

daffl added a commit that referenced this pull request Jan 7, 2014

Merge pull request #629 from bitovi/each_list_bind
#each on undefined attributes not working anymore in 2.0.4

@daffl daffl merged commit 0ae37bb into master Jan 7, 2014

1 check passed

default The Travis CI build passed
Details

@daffl daffl deleted the each_list_bind branch Jan 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment