Suggested fix to broken attr behaviour #671

Merged
merged 1 commit into from Jan 23, 2014

Conversation

Projects
None yet
4 participants
@RpprRoger
Contributor

RpprRoger commented Jan 16, 2014

This is my fix for the bug/inconsistency mentioned in #667

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jan 16, 2014

Contributor

This actually looks pretty good for 2.0.5 and doesn't seem to interfere with anything else.

/cc @justinbmeyer, @thecountofzero

Contributor

daffl commented Jan 16, 2014

This actually looks pretty good for 2.0.5 and doesn't seem to interfere with anything else.

/cc @justinbmeyer, @thecountofzero

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jan 16, 2014

Contributor

Actually, I wasn't aware this code existed in the first place. It performs double reads for every attr call with a ".".

#257 and #269 and this commit are related: a80bd62

I'm not sure what to do as I'd prefer not to do double reads.

Contributor

justinbmeyer commented Jan 16, 2014

Actually, I wasn't aware this code existed in the first place. It performs double reads for every attr call with a ".".

#257 and #269 and this commit are related: a80bd62

I'm not sure what to do as I'd prefer not to do double reads.

@andykant

This comment has been minimized.

Show comment
Hide comment
@andykant

andykant Jan 23, 2014

Contributor

If there is a double read I think it's worthwhile for the consistency, although in my testing the amount of lookups in both cases was roughly the same.

Optimally you wouldn't have data organized like this in cases where the performance was an issue.

Contributor

andykant commented Jan 23, 2014

If there is a double read I think it's worthwhile for the consistency, although in my testing the amount of lookups in both cases was roughly the same.

Optimally you wouldn't have data organized like this in cases where the performance was an issue.

andykant added a commit that referenced this pull request Jan 23, 2014

Merge pull request #671 from RpprRoger/fix-map-attr
Suggested fix to broken attr behaviour

@andykant andykant merged commit 4544579 into canjs:master Jan 23, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment